Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes dependency to git-rev #14

Merged
merged 1 commit into from Jul 11, 2017
Merged

removes dependency to git-rev #14

merged 1 commit into from Jul 11, 2017

Conversation

conradkleinespel
Copy link

@conradkleinespel conradkleinespel commented Apr 1, 2017 •
edited

Hey everyone !

This commit removes a dependency, making the library a bit easier to audit/inspect.

I don't know if you still aim to support node 0.8.0, so I have not gone ahead and removed the merge dependency. But on node >= 4.0.0, Object.assign is supported and could replace merge. Let me know if you need a hand removing that dependency, I'm happy to help.

I've bumped the minor version up. I don't know if this is what you'd want though, since dependents on postmark might have been using git-rev without explicitly installing it. So this PR is theoretically a breaking change.

Best regards, Conrad

@atheken atheken merged commit 8510405 into ActiveCampaign:master Jul 11, 2017
@conradkleinespel
Copy link
Author

@conradkleinespel conradkleinespel commented Jul 11, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@conradkleinespel @atheken